Skip to content

Disallow session closure for Cambridge Audio#171036

Merged
erwindouna merged 3 commits into
home-assistant:devfrom
noahhusby:fix/disallow-streammagic-session
May 18, 2026
Merged

Disallow session closure for Cambridge Audio#171036
erwindouna merged 3 commits into
home-assistant:devfrom
noahhusby:fix/disallow-streammagic-session

Conversation

@noahhusby
Copy link
Copy Markdown
Contributor

@noahhusby noahhusby commented May 17, 2026

Proposed change

Passes flag to Cambridge Audio upstream library indicating that the provided session should not be closed.
Depends on: #171035

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings May 17, 2026 21:39
Copilot AI reviewed May 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Bumps the aiostreammagic library from 2.13.0 to 2.13.1 and updates the Cambridge Audio integration to pass the new should_close_session=False argument when constructing the client with a shared Home Assistant session.

Changes:

  • Update aiostreammagic dependency to 2.13.1 in manifest and requirements files.
  • Pass should_close_session=False to StreamMagicClient to prevent closing the shared aiohttp session.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
requirements_test_all.txt Bumped aiostreammagic to 2.13.1.
requirements_all.txt Bumped aiostreammagic to 2.13.1.
homeassistant/components/cambridge_audio/manifest.json Bumped aiostreammagic requirement to 2.13.1.
homeassistant/components/cambridge_audio/init.py Pass should_close_session=False when creating StreamMagicClient with the shared session.

@noahhusby noahhusby marked this pull request as ready for review May 18, 2026 01:02
erwindouna
erwindouna requested changes May 18, 2026
View reviewed changes
Comment thread homeassistant/components/cambridge_audio/manifest.json
"loggers": ["aiostreammagic"],
"quality_scale": "platinum",
"requirements": ["aiostreammagic==2.13.0"],
"requirements": ["aiostreammagic==2.13.1"],
Copy link
Copy Markdown
Member

@erwindouna erwindouna May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're bringing in a dependency upgrade. Please provide a changelog and/or diff comparison. :)

Copy link
Copy Markdown
Contributor Author

@noahhusby noahhusby May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency bump was in a former PR, just required a rebase :)

@home-assistant home-assistant Bot marked this pull request as draft May 18, 2026 06:10
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented May 18, 2026

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@noahhusby noahhusby marked this pull request as ready for review May 18, 2026 13:32
Copilot AI review requested due to automatic review settings May 18, 2026 13:32
@home-assistant home-assistant Bot requested a review from erwindouna May 18, 2026 13:32
Copilot AI reviewed May 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

erwindouna
erwindouna approved these changes May 18, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@erwindouna erwindouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @noahhusby!

@erwindouna erwindouna merged commit f0a5ce7 into home-assistant:dev May 18, 2026
33 checks passed
@noahhusby noahhusby deleted the fix/disallow-streammagic-session branch May 18, 2026 13:53
@noahhusby noahhusby mentioned this pull request May 18, 2026
Open
jnimmo pushed a commit to jnimmo/core that referenced this pull request May 18, 2026
@noahhusby @jnimmo
Disallow session closure for Cambridge Audio (home-assistant#171036)
8d16804
@github-actions github-actions Bot locked and limited conversation to collaborators May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@erwindouna erwindouna erwindouna approved these changes

Assignees

No one assigned

Labels

bugfix by-code-owner cla-signed integration: cambridge_audio Quality Scale: platinum small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@noahhusby @erwindouna