Skip to content

fix: The intermittent abnormality of etcd has caused registration failure. (#3464) #3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fltfh wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: The intermittent abnormality of etcd has caused registration failure. (#3464) #3478

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acfdd14
fix: The intermittent abnormality of etcd has caused registration fa…
Nov 21, 2024
bd65ae3
Merge branch 'main' into fix/etcd-registry-retry-failed
fltfh Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions contrib/registry/etcd/registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,8 @@ func (r *Registry) heartBeat(ctx context.Context, leaseID clientv3.LeaseID, key
if curLeaseID == 0 {
// try to registerWithKV
var retreat []int
for retryCnt := 0; retryCnt < r.opts.maxRetry; retryCnt++ {
var retryCnt int
for retryCnt = 0; retryCnt < r.opts.maxRetry; retryCnt++ {
if ctx.Err() != nil {
return
}
Expand Down Expand Up @@ -202,7 +203,7 @@ func (r *Registry) heartBeat(ctx context.Context, leaseID clientv3.LeaseID, key
retreat = append(retreat, 1<<retryCnt)
time.Sleep(time.Duration(retreat[randSource.Intn(len(retreat))]) * time.Second)
}
if _, ok := <-kac; !ok {
if _, ok := <-kac; !ok && retryCnt >= r.opts.maxRetry {
// retry failed
return
}
Expand Down