Add ical_value property to vFrequency#1380
Closed
xxiaoxiong wants to merge 1 commit into
Closed
Conversation
- Add ical_value property with type hints and docstring - Returns the underlying string value - Validates frequency is one of 7 valid values - Add comprehensive tests for ical_value (7 test cases) - All tests pass - Code formatted with ruff Relates to collective#876
xxiaoxiong
requested review from
SashankBhamidi,
angatha,
niccokunzmann and
stevepiercy
as code owners
stevepiercy
added
the
ai-suspicion
Member
|
@xxiaoxiong thank you for opening this PR. Because you haven't responded to the reviews and CI failures, I'm closing all of your PRs to let other contributors know that they are free to work on it. You're welcome to address our comments, resolve the matters, and reopen your pull request at any time, specifically to address the question of AI usage and add a change log, per Contribute. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
ical_valueproperty tovFrequency, contributing to Issue #876.Changes
ical_valueproperty tovFrequency(src/icalendar/prop/recur/frequency.py)str- The frequency string valuestr5545#section-3.3.10Tests
test_vFrequency.pywith 7 comprehensive test cases:test_ical_value_daily- Tests DAILY frequencytest_ical_value_all_frequencies- Tests all 7 valid frequenciestest_ical_value_from_ical- Tests with parsed ical stringstest_ical_value_case_insensitive- Tests case handlingtest_ical_value_invalid_frequency- Tests validationtest_ical_value_weekly- Tests WEEKLY frequencytest_ical_value_yearly- Tests YEARLY frequencyQuality Checks
Relates to #876