metrics, node: lean_block_proposal attestation build metrics#914
Merged
Conversation
Instrument getProposalAttestations with cross-client lean_* phase timing, build/child-payload counters, and attestation-data/aggregate histograms. Distinct from zeam_compact_attestations_* (compactAttestations FFI only).
Align phase label with leanSpec #753; compact is spec-level recursive merge, not an FFI-specific step name.
2 tasks
anshalshukla
previously approved these changes
May 21, 2026
CI stalled finalization at slot 12 so node3 never emitted its own new_finalization within 480s. Accept head-event progress after the delayed node3 start (original #484 approach) while still honoring node3 finalization or a later global finalization when they occur. Remove the per-event SUCCESS log that fired before assertions.
CI records ~25 new_head events by first finalization and only one more before the chain stalls; requiring +5 never tripped got_node3_sync. Use strictly-more-than baseline and re-check at timeout exit.
anshalshukla
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds cross-client
lean_block_proposal_*metrics for block-proposal attestation selection ingetProposalAttestationsUnlocked, aligned with leanSpec #753:lean_block_proposal_attestation_build_phase_seconds{phase}—select_payloads,compact_ffi,stf_simulatelean_block_proposal_attestation_builds_totallean_block_proposal_child_payloads_consumed_totallean_block_proposal_attestation_data_selectedlean_block_proposal_aggregates_selectedThese are not the same as
zeam_compact_attestations_*(per-compactAttestationsFFI time and attestation row in/out only).lean_block_building_payload_aggregation_time_secondsremains the wall-clock total for the whole call.Test plan
zig build test