fix(opencode): propagate TUI worker RPC errors#28044
Open
PeterPonyu wants to merge 1 commit into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #28043
Type of change
What does this PR do?
Makes worker RPC failures return a structured error response instead of rejecting the worker message handler. The parent RPC client now rejects the matching request and can keep handling later responses.
This keeps TUI worker communication from getting stuck behind a failed RPC call.
How did you verify your code works?
cd packages/opencode && bun test test/util/rpc.test.ts test/lsp/index.test.ts-> 10 pass, 0 failcd packages/opencode && bun typecheck-> passgit diff --check-> passScreenshots / recordings
Not a UI change.
Checklist
Made with Cursor