Skip to content

fix(ci): apply prettier --write to 4 files with formatting drift#1802

Closed
Skords-01 wants to merge 1 commit into
mainfrom
devin/1777938519-fix-prettier-formatting-on-main
Closed

fix(ci): apply prettier --write to 4 files with formatting drift#1802
Skords-01 wants to merge 1 commit into
mainfrom
devin/1777938519-fix-prettier-formatting-on-main

Conversation

@Skords-01
Copy link
Copy Markdown
Owner

@Skords-01 Skords-01 commented May 4, 2026

Summary

Pure formatting fix. No semantic changes. Files were drifted on main (failing pnpm format:check, which is part of the required check CI job). This blocks all PR merges — currently 5 open Dependabot PRs (#1650, #1559, #1587, #1557, #1558).

Files touched (formatting-only):

  • apps/console/src/openclaw/parse-mode-guard.test.ts
  • docs/diagnostics/README.md
  • docs/initiatives/0009-agent-os-hardening.md
  • scripts/check-localstorage-allowlist.mjs

Governing Skill

  • Primary skill: sergeant-bugfix-and-regression

Playbook

  • Primary playbook: n/a (pure prettier auto-fix)
  • Why this playbook: trivial mechanical fix, no design judgment.
  • If no playbook matched, why: prettier-drift cleanup is too small for a playbook.

Verification

node_modules/.bin/prettier --check .
# Before: 4 warnings, exit 1
# After:  All matched files use Prettier code style!  exit 0

Additional checks:

  • Local smoke: prettier check exits 0.
  • git diff --stat shows only whitespace/format changes (no semantic edits).

Docs and Governance

  • I updated docs that changed with the behavior, contract, workflow, or rollout. (n/a — no behavior change)
  • I checked whether AGENTS.md needed an update. (no)
  • I checked whether a playbook or skill needed an update. (no)
  • I checked whether governance docs or review docs needed an update. (no)

Updated docs:

  • docs/diagnostics/README.md — pure formatting reflow.
  • docs/initiatives/0009-agent-os-hardening.md — pure formatting reflow.

Risk and Rollout

  • User-visible risk: none.
  • Rollout / deploy order: merge → CI on Dependabot bumps unblocks.
  • Backout plan: revert this commit.

Hard Rule #15

  • I read AGENTS.md before coding.
  • Internal docs I touched are in Ukrainian. (yes — the docs were already in Ukrainian; only formatting changed)
  • I did not use --no-verify.

Reviewer Notes

The diff is exclusively prettier whitespace/wrap. Confirm by running git diff -w (whitespace-only).


Summary by cubic

Applied prettier --write to four files on main to fix the pnpm format:check CI failure and unblock PR merges. Formatting-only; no semantic changes.

Written for commit 0aef327. Summary will update on new commits.

Summary by CodeRabbit

  • Tests

    • Updated test formatting and descriptions for validator checks.
  • Documentation

    • Improved table formatting and layout in diagnostic and initiative documentation for better readability.
  • Style

    • Refactored code formatting in validation scripts for consistency.

Pure formatting fix. No semantic changes. Files were drifted on main
(failing 'pnpm format:check' which is part of the required 'check' CI
job), blocking all PR merges.

Files:
- apps/console/src/openclaw/parse-mode-guard.test.ts
- docs/diagnostics/README.md
- docs/initiatives/0009-agent-os-hardening.md
- scripts/check-localstorage-allowlist.mjs

Local verification: 'node_modules/.bin/prettier --check .' exits 0
after this commit (was exit 1 with 4 warnings on main).

Why this is needed: required CI status check 'check' runs
'pnpm format:check' which runs 'prettier --check .'. The prettier
warnings cause non-zero exit, which fails 'check', which blocks all PR
merges (currently affecting 5 open Dependabot PRs: #1650, #1559,

Co-Authored-By: Бу Ка <dmytro.s.stakhov@gmail.com>
#1587, #1557, #1558).
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sergeant Ready Ready Preview, Comment May 4, 2026 11:49pm

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c692caf9-8bb2-41bc-afe7-ecb3c4676dcb

📥 Commits

Reviewing files that changed from the base of the PR and between ef8c5f9 and 0aef327.

📒 Files selected for processing (4)
  • apps/console/src/openclaw/parse-mode-guard.test.ts
  • docs/diagnostics/README.md
  • docs/initiatives/0009-agent-os-hardening.md
  • scripts/check-localstorage-allowlist.mjs

📝 Walkthrough

Walkthrough

Minor formatting and documentation updates across test code, scripts, and docs files. Changes include test description rewording, error message reformatting, and Markdown table alignment adjustments. No functional behavior is altered.

Changes

Formatting & Documentation Cleanup

Layer / File(s) Summary
Test Code Formatting
apps/console/src/openclaw/parse-mode-guard.test.ts
Error throw statement converted from multi-line to single-line format; test description string rewording from double-quoted to single-quoted syntax.
Script Code Formatting
scripts/check-localstorage-allowlist.mjs
Validation conditional for budget.production reflowed across multiple lines; error message example JSON and placeholder text reformatted.
Documentation Formatting
docs/diagnostics/README.md, docs/initiatives/0009-agent-os-hardening.md
Markdown table structures normalized with consistent header separators and row alignment; content values unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • Skords-01/Sergeant#1568: Main PR adjusts parse_mode validator test, while retrieved PR modifies handler.ts to use HTML parse_mode for /help.
  • Skords-01/Sergeant#1589: Both PRs modify the parseBudgetFile function in scripts/check-localstorage-allowlist.mjs.
  • Skords-01/Sergeant#1731: Both PRs normalize the "Поточний прогрес" table in docs/initiatives/0009-agent-os-hardening.md.

Suggested labels

size/XS

Poem

A rabbit hops through formatted lines,
Tables align with careful signs,
Error messages now shine so bright,
Markdown spacing—just right! ✨🐰

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: applying Prettier formatting to 4 files with formatting drift to fix CI failures.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch devin/1777938519-fix-prettier-formatting-on-main
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch devin/1777938519-fix-prettier-formatting-on-main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Skords-01
Copy link
Copy Markdown
Owner Author

Closing — #1802 was based on stale main (missing #1778 i18n governance-sync fix). Replaced by fresh PR with current set of drifted files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant