Skip to content

docs(agents): merge release-* playbooks into release.md (init 0009 PR 2.3)#1718

Closed
Skords-01 wants to merge 5 commits into
mainfrom
devin/1777904435-pr23-merge-release-playbooks
Closed

docs(agents): merge release-* playbooks into release.md (init 0009 PR 2.3)#1718
Skords-01 wants to merge 5 commits into
mainfrom
devin/1777904435-pr23-merge-release-playbooks

Conversation

@Skords-01
Copy link
Copy Markdown
Owner

@Skords-01 Skords-01 commented May 4, 2026

Summary

Phase 2 PR 2.3 of initiative 0009. Replaces #1705 (closed because the GitHub PR head ref got stuck at d739add2 and would not resync after pushing the deploy-config-change.md fix; closing did not allow reopen). Same branch, same content, plus the schema-fix commit that PR 1705 was missing.

Merges the three narrowly-scoped release playbooks into one consolidated docs/playbooks/release.md with a mermaid decision tree and three sections (Web + API, Mobile shell (Capacitor), Expo). Old files become Status: Deprecated stubs that point at the matching section.

  • New: docs/playbooks/release.md — H1, freshness, Status, ≤240-char Trigger, Owner surface (sergeant-deploy-and-observability), decision tree, three numbered sections, Verification with 6 checkboxes, when-not-to-use, related.
  • Deprecated stubs: release-web-and-api.md, release-mobile-shell.md, release-expo-mobile.md keep a stable URL for incident logs / past PRs / git blame and link to release.md#… anchors.
  • Updated references: docs/agents/specialists-mapping.md, docs/architecture/service-catalog.md, docs/governance/release-policy.md, docs/playbooks/playbook-catalog.md, docs/playbooks/INDEX.md (regenerated), docs/playbooks/run-weekly-operator-digest.md, docs/playbooks/retire-feature-flag.md, four SKILL.md files (sergeant-review-and-merge, sergeant-web-ui, sergeant-server-api, sergeant-mobile-expo) and .agents/skills-lock.json.
  • Out-of-scope CI unblocker: one-line shortening of the Trigger in docs/playbooks/deploy-config-change.md (was 275 chars > 240 schema cap; pre-existing on main). Mirrors the same fix proposed in docs(docs): mark initiative 0011 phase 1 as complete (4/4 merged) #1693; included here per user request to make CI green for the consolidation PR — no other change to that file.

Status semantics note: the playbook schema enum is {Active, Scaffolded, Deprecated, Archived} (AGENTS.md Hard Rule #10). The initiative spec used the word "Superseded"; we keep the Status: line schema-valid and add an explicit > **Superseded by:** [release.md § …](…) line right under it, which matches the existing "Deprecated — describes a behaviour we are replacing; reference the replacement" rule.

Validation

  • pnpm docs:check-playbook-schema → OK (44 playbooks).
  • pnpm docs:check-playbook-index → OK after regenerating INDEX.md and shortening the new release.md Trigger to 236/240 chars.
  • pnpm lint:skills → OK (12 skills).
  • pnpm docs:check-links --no-external → only pre-existing broken internal links (5, all unrelated to this PR).
  • pnpm format → OK.

Hard Rule #5 (Conventional Commits)

  • Type and scope match the table in AGENTS.md (docs(agents) for playbook/skill consolidation).

Hard Rule #15 (freshness headers)

  • Touched governance / playbook / skill files have a Last validated: YYYY-MM-DD by @owner. Next review: YYYY-MM-DD. header.
  • Schema check (pnpm docs:check-playbook-schema) passes for all 44 playbooks (Trigger ≤240 chars, Status enum, Owner+Governing skill, Verification ≥1 checkbox).
  • Internal docs I touched are in Ukrainian — N/A. The consolidated playbooks stay in English (existing convention; matches the rest of docs/playbooks/). Ukrainian translation of operator-facing playbooks is its own follow-up tracked in the initiative.

Summary by cubic

Consolidates the three release playbooks into a single canonical docs/playbooks/release.md with a decision tree and sections for Web + API, Capacitor shell, and Expo. Deprecates the old playbooks, updates references across docs, and fixes a trigger-length schema error to keep CI green.

  • Refactors
    • Added docs/playbooks/release.md (decision tree, three sections, verification checklist).
    • Deprecated release-web-and-api.md, release-mobile-shell.md, and release-expo-mobile.md as stubs that link to the new anchors.
    • Updated references in service catalog, release policy, playbook catalog/INDEX, weekly digest, feature-flag retirement, and sergeant-* SKILL docs; refreshed skills-lock.json.
    • Shortened the Trigger in deploy-config-change.md to meet the ≤240-char schema cap; regenerated the playbook index.

Written for commit 2311c3c. Summary will update on new commits.

Summary by CodeRabbit

  • Documentation
    • Consolidated three separate release playbooks (Expo mobile, mobile shell, web+API) into a single unified release guide.
    • Deprecated individual release procedures as redirects to the canonical release playbook.
    • Updated all governance policies, operational documentation, and playbook cross-references to point to the new consolidated guide.

devin-ai-integration Bot and others added 5 commits May 4, 2026 14:30
… 2.3)

Consolidate three narrowly-scoped release playbooks into a single
docs/playbooks/release.md with a mermaid decision tree and three
sections:

- Web + API
- Mobile shell (Capacitor)
- Expo

Old files (release-web-and-api, release-mobile-shell, release-expo-mobile)
become Status: Deprecated stubs that link to the new sections, so
existing bookmarks, audit logs, and PR references keep resolving.

Update references in:
- specialists mapping, service catalog, release policy
- playbook catalog and INDEX (regenerated)
- run-weekly-operator-digest, retire-feature-flag
- sergeant-review-and-merge / sergeant-web-ui / sergeant-server-api /
  sergeant-mobile-expo SKILL.md (skills-lock regenerated)

Note: schema status enum is {Active, Scaffolded, Deprecated, Archived}
(AGENTS.md Hard Rule #10), so old files use Status: Deprecated with an
explicit "Superseded by:" line pointing to the merged playbook.

Co-Authored-By: Ка А <dmytro.s.stakhov@gmail.com>
Follow-up to the trigger-length fix on docs/playbooks/release.md
(\u2264 240 chars per playbook-schema): regenerate INDEX.md so the trigger
column matches the playbook source. Also restores the auto-generator
freshness marker (`by @devin-ai`).

Co-Authored-By: Ка А <dmytro.s.stakhov@gmail.com>
Co-Authored-By: Ка А <dmytro.s.stakhov@gmail.com>
Pre-existing violation on `main`: Trigger was 275 chars > 240. The
schema gate is enforced in the same CI job as the playbook trigger
index check, so it has to pass for this PR's CI to go green.

Mirrors the fix already proposed in PR #1693; included here so PR 2.3
does not block on the merge order.

Co-Authored-By: Ка А <dmytro.s.stakhov@gmail.com>
Co-Authored-By: Ка А <dmytro.s.stakhov@gmail.com>
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sergeant Ready Ready Preview, Comment May 4, 2026 4:56pm

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 54e60b4d-9ffb-4bfb-862c-3094ba406e28

📥 Commits

Reviewing files that changed from the base of the PR and between 10aed13 and 2311c3c.

📒 Files selected for processing (17)
  • .agents/skills-lock.json
  • .agents/skills/sergeant-mobile-expo/SKILL.md
  • .agents/skills/sergeant-review-and-merge/SKILL.md
  • .agents/skills/sergeant-server-api/SKILL.md
  • .agents/skills/sergeant-web-ui/SKILL.md
  • docs/agents/specialists-mapping.md
  • docs/architecture/service-catalog.md
  • docs/governance/release-policy.md
  • docs/playbooks/INDEX.md
  • docs/playbooks/deploy-config-change.md
  • docs/playbooks/playbook-catalog.md
  • docs/playbooks/release-expo-mobile.md
  • docs/playbooks/release-mobile-shell.md
  • docs/playbooks/release-web-and-api.md
  • docs/playbooks/release.md
  • docs/playbooks/retire-feature-flag.md
  • docs/playbooks/run-weekly-operator-digest.md

📝 Walkthrough

Walkthrough

This PR consolidates release playbooks across four production surfaces into a single canonical playbook. A new docs/playbooks/release.md is introduced with unified procedures for Web+API, Mobile shell (Capacitor), and Expo releases. Three existing playbooks are converted to deprecated stubs with redirects. Skills, mappings, policies, and related playbook references are updated to point to the consolidated resource. Skill hashes are updated to reflect documentation changes.

Changes

Release Playbook Consolidation

Layer / File(s) Summary
New Consolidated Playbook
docs/playbooks/release.md
Creates unified release procedures covering Web+API, Mobile shell (Capacitor), and Expo surfaces with decision tree, surface-specific steps, verification checklist, and guidance on when not to use.
Playbook Stub Redirects
docs/playbooks/release-{web-and-api,mobile-shell,expo-mobile}.md
Converts three previously active playbooks to deprecated stubs that redirect readers to corresponding sections in the new consolidated release.md.
Playbook Index & Catalog Updates
docs/playbooks/{INDEX,playbook-catalog}.md
Updates trigger descriptions and scenario catalog entries to reference the new unified release.md instead of the three separate playbooks.
Skills Documentation Updates
.agents/skills/sergeant-{mobile-expo,review-and-merge,server-api,web-ui}/SKILL.md
Updates playbook references to point to the consolidated release.md instead of release-specific playbooks.
Skills Lock Hash Updates
.agents/skills-lock.json
Updates computedHash values for four skills whose SKILL.md documentation changed.
Governance & Mapping Documentation
docs/governance/release-policy.md, docs/agents/specialists-mapping.md, docs/architecture/service-catalog.md
Updates canonical playbook references, specialist governance rules, and service catalog runbook links to use the consolidated release.md.
Related Playbook Cross-References
docs/playbooks/{retire-feature-flag,run-weekly-operator-digest}.md, docs/playbooks/deploy-config-change.md
Updates "Related playbooks and skills" links and metadata dates where they reference release procedures.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested labels

size/M

Poem

🐰 A rabbit hops through docs with glee,
Four surfaces, now unified you see!
Release flows merged in one bright tome,
Old stubs now point folks safely home.
Consolidated paths, so clear and neat,
One source of truth—a treat! 🎉

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch devin/1777904435-pr23-merge-release-playbooks

Review rate limit: 6/10 reviews remaining, refill in 22 minutes and 16 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/M label May 4, 2026
@Skords-01 Skords-01 closed this May 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

⏱️ CI Pipeline Duration Report

Based on the last 50 successful runs on the default branch.

Overall Pipeline

Metric Value
p50 6m 26s
p95 7m 55s
p99 9m 3s
Current run 6m 23s
vs p95 -19.4%

Trend (last 20 runs): ▃▃▁▂▃▃▃▂▃▃▂▂▄▃▃▆▅▄█▆

Per-Job Breakdown

Job p50 p95 p99 Current vs p95
Accessibility (axe-core) 2m 5s 2m 21s 2m 23s 0s -100.0%
Commit messages (commitlint) 0s 0s 0s 36s N/A
Critical-flow E2E (Playwright) 1m 36s 1m 44s 1m 44s 6m 0s +246.2%
Migration lint (AGENTS rule 0s 0s 0s 7s N/A
Pipeline duration (p95 trend) 26s 27s 27s
Secret scan (gitleaks) 8s 11s 11s 9s -18.2%
Smoke E2E (Playwright) 1m 26s 1m 40s 1m 40s
Test coverage (vitest) 2m 4s 2m 33s 2m 33s 2m 31s -1.3%
Workflow lint (actionlint) 7s 7s 7s 6s -14.3%
check 4m 12s 4m 54s 5m 6s 48s -83.7%
tsconfig strict guard (PR-1.A) 5s 14s 14s 5s -64.3%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant