fix(maru): address PR 3126 workflow follow-ups#3164
Conversation
coordinator Changelog Preview (informational)[Unreleased] diff (commits touching
|
linea-besu Changelog Preview (informational)[Unreleased] diff (commits touching
|
postman Changelog Preview (informational)[Unreleased] diff (commits touching
|
tx-exclusion-api Changelog Preview (informational)[Unreleased] diff (commits touching
|
prover Changelog Preview (informational)[Unreleased] diff (commits touching
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e70b551. Configure here.
| - name: Store reports | ||
| if: failure() | ||
| uses: actions/upload-artifact@v4 | ||
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 |
There was a problem hiding this comment.
Silent major version bump v4 to v7 for upload-artifact
Medium Severity
The "Store reports" step's actions/upload-artifact was silently upgraded from @v4 to @043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 — a major version bump from v4 to v7. The second upload-artifact instance (Jacoco data) was already on @v7, so its pin is correct. However, upgrading the first instance across three major versions while the PR describes only "pinning" actions risks introducing breaking behavioral changes (e.g., different upload merge strategies, changed default inputs) without the team's awareness.
Reviewed by Cursor Bugbot for commit e70b551. Configure here.


#2540
Summary
Follow-up cleanup from #3126 for items 1, 3, 7, and 9:
--rerun-tasksfrommaru-testing.ymland drop the flaky-debug comment.percentileBucketscomment fromConsensusMetrics.Validation
git diff --check./gradlew :maru:app:compileKotlinNote
Low Risk
Low risk because changes are limited to CI workflow hygiene (pinning third-party actions) and minor test job behavior changes (removing
--rerun-tasks), without impacting runtime or protocol logic.Overview
CI hardening: Pins several third-party actions in Maru workflows to immutable SHAs (e.g.,
azure/setup-helm,lhotari/action-upterm,softprops/action-gh-release,codecov/test-results-action, andactions/upload-artifact) to satisfy supply-chain/security guidance.Workflow behavior tweaks: Removes
--rerun-tasks(and the related flaky-test debug comment) frommaru-testing.yml, and does small YAML hygiene fixes (newline/whitespace).Cleanup: Deletes a stale comment in
ConsensusMetrics.ktabout unsupportedpercentileBucketsin the histogram API.Reviewed by Cursor Bugbot for commit e70b551. Bugbot is set up for automated code reviews on this repo. Configure here.